Mark put-clojure-indent safe for use in LocalVariables, .dir-locals.el, etc. #598
Conversation
|
I don't have access to circleci at the moment (wondering why their test results aren't public without a login), but since the --- a/Makefile
+++ b/Makefile
@@ -38,5 +38,5 @@ test-checks:
test-bytecomp: $(SRCS:.el=.elc-test)
%.elc-test: %.el elpa
- $(CASK) exec $(EMACS) --no-site-file --no-site-lisp --batch \
- -l test/clojure-mode-bytecomp-warnings.el $
+ $(CASK) exec $(EMACS) -L . --no-site-file --no-site-lisp --batch \
+ -l test/clojure-mode-bytecomp-warnings.el $<
It gets further, but fails like this: After moving some functions around and removing the |
rlbdv
force-pushed
the
validate-put-clojure-indent-as-safe
branch
from
5baa06e to
99d3de9
Compare
|
Not sure what's going on in CI with 25 and master, but I went ahead and fixed up everything that was causing trouble with Emacs 27 here. |
|
i.e. I moved those declarations before their first use, and added the missing |
|
Your changes look good to me overall, but I won't be able to review them more carefully until next week. Sorry about the slow response. |
|
No worries, and no rush -- if I get time, I might see what's up with emacs 25 and master later, either locally, or in a vm. |
rlbdv
force-pushed
the
validate-put-clojure-indent-as-safe
branch
from
99d3de9 to
c442aa5
Compare
|
Fixed the issues. Emacs 25 doesn't have |
Add a put-clojure-indent form validator and attach it as a
safe-local-eval-function property so that safe invocations won't
trigger open-file prompts when used in local variables, or when added
to .dir-locals.el like this:
((clojure-mode
(eval . (put-clojure-indent 'defrecord '(2 :form :form (1))))))
For now, only support specs specified as lists, not vectors.
Otherwise test-bytecomp fails with: In toplevel form: clojure-mode.el:493:25:Error: reference to free variable `clojure--let-regexp'
Otherwise test-bytecomp fails like this: In toplevel form: clojure-mode.el:1860:23:Error: assignment to free variable `clojure-cached-ns'
Otherwise test-bytecomp fails like this: In toplevel form: clojure-mode.el:3015:1:Error: the function `clojure-no-space-after-tag' is not known to be defined.
In toplevel form: clojure-mode.el:1135:1: Error: custom-declare-variable `clojure-align-separator' docstring wider than 80 characters make: *** [Makefile:41: clojure-mode.elc-test] Error 1
rlbdv
force-pushed
the
validate-put-clojure-indent-as-safe
branch
from
4af9825 to
58836df
Compare
|
Well done! |
Add a put-clojure-indent form validator and attach it as a
safe-local-eval-function property so that safe invocations won't
trigger open-file prompts when used in local variables, or when added
to .dir-locals.el like this:
((clojure-mode (eval . (put-clojure-indent 'defrecord '(2 :form :form (1))))))For now, only support specs specified as lists, not vectors.
This work assumes that we don't want to rely on any existing validation, and so attempts to perform thorough validation up front. Also happy to make further changes, but thought I'd post what I have, to see if I'm on a reasonable track.